Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to org.apache.velocity:velocity-engine-core:2.3 #639

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

baulea
Copy link
Contributor

@baulea baulea commented Mar 8, 2024

Upgrade to org.apache.velocity:velocity-engine-core:2.3

Fixes Issue

PR Branch
https://github.com/baulea/zerocode/tree/upgrade_velocity-engine-core

Motivation and Context

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

Copy link
Collaborator

@a1shadows a1shadows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a1shadows a1shadows merged commit c43442a into authorjapps:master Mar 10, 2024
1 check passed
@baulea baulea deleted the upgrade_velocity-engine-core branch March 10, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants