Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Jackson, Guice, Guava and jsonassert #641

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

a1shadows
Copy link
Collaborator

@a1shadows a1shadows commented Mar 9, 2024

Fixes Issue

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Notable changes include

  1. adding null checks to JsonNodes because recent Jackson versions deserialize null values to Java null instead of Jackson NullNode
  2. Moving from javax.inject to jakarta.inject with latest Guice version

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@a1shadows
Copy link
Collaborator Author

@authorjapps Can you review this? There are a lot of small changes with this upgrade

@baulea
Copy link
Contributor

baulea commented Mar 10, 2024

@a1shadows With #638 junit was upgraded from 4.12 to 4.13.2. This recent PR #641 contains a downgrade to 4.12 again. Would you please change that?

@a1shadows
Copy link
Collaborator Author

@a1shadows With #638 junit was upgraded from 4.12 to 4.13.2. This recent PR #641 contains a downgrade to 4.12 again. Would you please change that?

@baulea Done

Copy link
Owner

@authorjapps authorjapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. CI also Green 🟢

@a1shadows a1shadows merged commit f070a3d into authorjapps:master Mar 11, 2024
1 check passed
@a1shadows a1shadows deleted the update_dependencies branch March 14, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the libraries and make it compatible with Java8
3 participants