-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wiremock 2.27.2 and json-path 2.9.0 #647
Merged
a1shadows
merged 8 commits into
authorjapps:master
from
baulea:upgrade_wiremock_and_json-path
Mar 18, 2024
Merged
Upgrade wiremock 2.27.2 and json-path 2.9.0 #647
a1shadows
merged 8 commits into
authorjapps:master
from
baulea:upgrade_wiremock_and_json-path
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @a1shadows, @authorjapps Could you please have a look at one more PR? |
StrSubstitutor -> StringSubstitutor org.mockito.runners.MockitoJUnitRunner org.mockito.Matchers+ ...
a1shadows
requested changes
Mar 17, 2024
a1shadows
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade wiremock 2.27.2 and json-path 2.9.0
Fixes Issue
PR Branch
https://github.com/baulea/zerocode/tree/upgrade_wiremock_and_json-path
Motivation and Context
resolves #635
Checklist:
Unit tests added
Integration tests added Integration test corrected
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testing
module(if applicable) ?Kafka test added to
kafka-testing
module(if applicable) ?