Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wiremock 2.27.2 and json-path 2.9.0 #647

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

baulea
Copy link
Contributor

@baulea baulea commented Mar 15, 2024

Upgrade wiremock 2.27.2 and json-path 2.9.0

Fixes Issue

PR Branch
https://github.com/baulea/zerocode/tree/upgrade_wiremock_and_json-path

Motivation and Context

resolves #635

Checklist:

  • Unit tests added

  • Integration tests added Integration test corrected

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@baulea
Copy link
Contributor Author

baulea commented Mar 16, 2024

Hello @a1shadows, @authorjapps Could you please have a look at one more PR?
Do you see any more task to be done before branching for JDK17? https://github.com/authorjapps/zerocode/milestone/2

StrSubstitutor -> StringSubstitutor
org.mockito.runners.MockitoJUnitRunner
org.mockito.Matchers+
...
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@baulea baulea requested a review from a1shadows March 17, 2024 14:17
Copy link
Collaborator

@a1shadows a1shadows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a1shadows a1shadows merged commit 9242eb7 into authorjapps:master Mar 18, 2024
1 check passed
@baulea baulea deleted the upgrade_wiremock_and_json-path branch March 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants