Update documentation on the V1 API protos #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
added
area/docs
jzelinskie
requested changes
Sep 17, 2021
| @@ -8,22 +8,34 @@ import "validate/validate.proto"; | |||
|
|
|||
There was a problem hiding this comment.
Can we rename this file, too? It should be permission_service.proto and not acl_service.proto
There was a problem hiding this comment.
Will renaming have any effects on the generated code (besides their filenames too)?
authzed/api/v1/core.proto
Outdated
| @@ -48,7 +46,7 @@ message ObjectReference { | |||
| } | |||
|
|
|||
| // ZedToken is used to provide causality metadata between Write and Check | |||
| // requests. | |||
| // requests. See the Consistency message in acl_service.proto for more information. | |||
There was a problem hiding this comment.
I'd move this last sentence onto a separate line and use the fully qualified name:
// ZedToken is used to provide causality metadata between Write and Check
// requests.
//
// See the authzed.api.v1.Consistency message for more information.
josephschorr
force-pushed
the
documentation
branch
from
1d5a49c
to
7b8e2f9
Compare
|
Updated |
josephschorr
force-pushed
the
documentation
branch
from
7b8e2f9
to
4b798db
Compare
Signed-off-by: Joseph Schorr <josephschorr@users.noreply.github.com>
josephschorr
force-pushed
the
documentation
branch
from
4b798db
to
d8d5d18
Compare
jzelinskie
approved these changes
Sep 17, 2021
josephschorr
added a commit
to josephschorr/api
that referenced
this pull request
Sep 30, 2022
josephschorr
added a commit
to josephschorr/api
that referenced
this pull request
Sep 30, 2022
josephschorr
added a commit
to josephschorr/api
that referenced
this pull request
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.