API changes in preparation for wildcard (public) support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
public-wildcard
branch
from
9e50b20
to
f510ee8
Compare
jzelinskie
reviewed
Dec 9, 2021
| @@ -48,7 +48,23 @@ message Relation { | |||
| } | |||
|
|
|||
| message TypeInformation { | |||
| repeated RelationReference allowed_direct_relations = 1; | |||
| repeated AllowedRelation allowed_direct_relations = 1; | |||
There was a problem hiding this comment.
Commenting for clarity. This needs to only be compatible with the serialized proto format, which we've tested that this change is.
jzelinskie
approved these changes
Dec 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See authzed/spicedb#1