add magefiles #115
Merged
add magefiles #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vroldanbet
commented
May 22, 2023
•
vroldanbet
commented
- introduces mage to handle common tasks
- improves proto generation so all tooling is pinned and it's run in CI exactly as it is locally
- updates all GH actions to use mage
vroldanbet
force-pushed
the
add-mage
branch
2 times, most recently
from
a7ff095
to
305f8ad
Compare
ecordell
reviewed
May 22, 2023
| @@ -1,23 +1,29 @@ | |||
| #!/usr/bin/env -S buf generate buf.build/authzed/api:125e39e67bf60b2d19c4de15aaa69cb1bcbda28c --template | |||
| #!/usr/bin/env -S go run github.com/bufbuild/buf/cmd/buf generate buf.build/authzed/api:125e39e67bf60b2d19c4de15aaa69cb1bcbda28c --template | |||
There was a problem hiding this comment.
this makes me think there's something we could do (in the future) with the buf api. fetch the latest tag and generate off it or something.
There was a problem hiding this comment.
that'd be nice, something that updates the tag used, and then generates the code
magefile.go
Outdated
There was a problem hiding this comment.
for consistency, name this mage.go?
There was a problem hiding this comment.
actually when you do mage -init it generates a magefile.go, why deviating from what the tool proposes?
There was a problem hiding this comment.
That's frustrating; I just based it off of the docs: https://magefile.org/zeroinstall/
inspired by authzed/spicedb, this adds magefiles to manage common tasks via CLI and have minimal differences with what's run in CI
ecordell
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.