Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Spanner connection pool size, enable gzip #1586

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Configurable Spanner connection pool size, enable gzip #1586

merged 2 commits into from
Oct 17, 2023

Conversation

ecordell
Copy link
Contributor

Builds on #1584, but removes the split pools for now so that we can test these other factors in isolation.

@ecordell ecordell requested a review from a team as a code owner October 17, 2023 13:32
@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system labels Oct 17, 2023
vroldanbet
vroldanbet approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell added this pull request to the merge queue Oct 17, 2023
Merged via the queue into authzed:main with commit a070d54 Oct 17, 2023
25 checks passed
@ecordell ecordell deleted the spanner-connpool branch October 17, 2023 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecordell @vroldanbet @jzelinskie