Use buffered channels for lookup results #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
this prevents leaf goroutines from getting stuck on write to a closed channel
ecordell
force-pushed
the
fix-lookup-goroutine-leak
branch
from
8a5b227
to
3fc8076
Compare
ecordell
commented
Nov 5, 2021
| @@ -378,6 +379,7 @@ func TestLookupResources(t *testing.T) { | |||
| t.Run(fmt.Sprintf("%s::%s from %s:%s#%s", tc.objectType, tc.permission, tc.subject.Object.ObjectType, tc.subject.Object.ObjectId, tc.subject.OptionalRelation), func(t *testing.T) { | |||
| require := require.New(t) | |||
| client, stop, revision := newPermissionsServicer(require, delta, memdb.DisableGC, 0) | |||
| defer goleak.VerifyNone(t, goleak.IgnoreCurrent()) | |||
There was a problem hiding this comment.
it looks weird to have this before defer stop(), but that lets IgnoreCurrent capture the running server's goroutines and check for leaks after stop()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents leaf goroutines from getting stuck on write to a channel nothing is reading from
(I haven't convinced myself that there are no other goroutine leaks in the lookup dispatch, but this is definitely a source of leaks)