Skip to content

Conversation

trknhr
Copy link
Contributor

@trknhr trknhr commented Jul 9, 2021

Hi

I found a snippet that I want to fix.
Although It set the asynchronous flag as false, errors were called in asynchronous events. This throw error cannot be detected by Autify because it detects only synchronous errors.

When this flag is set as false, xhr.send blocks later processes until receiving the server's response.
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Synchronous_and_Asynchronous_Requests#example_http_synchronous_request

Please check it. Thank you.

@trknhr trknhr requested a review from macoril as a code owner July 9, 2021 05:22
@meih
Copy link
Contributor

meih commented Jul 14, 2021

@trknhr
Thank you for your suggestion!
You will be the first-time contributor to this repo from outside Autify 🎉

At the same time, we care about your contribution in terms of your rights.
Upon merging, do you agree to allow other users to use the updated snippet?

Thank you!

@trknhr
Copy link
Contributor Author

trknhr commented Jul 14, 2021

@meih Thank you for your reply. There is no problem that other users use it.

@meih
Copy link
Contributor

meih commented Jul 15, 2021

Thank you! Your PR will be reviewed soon.

@meih meih merged commit 04b987e into autifyhq:master Jul 16, 2021
@autifyhq autifyhq locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants