Repository navigation
Native Torznab pacing can be bypassed by concurrent grabs and download retries #2731
Replies: 1 comment
Tracked in #2735. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Description
For a native Torznab indexer, the shared minimum request interval is not consistently applied across scheduled searches and paced torrent-file downloads. Two isolated cases reproduce on current develop:
WaitForMinIntervalis admitted immediately for the same indexer because search dispatch did not reserve that shared slot.DownloadTorrent(Pace: true)gets HTTP 500 and retries after the fixed 2-second backoff, even when its configured minimum interval is 5 seconds. Pacing is checked before the retry loop, not for each request attempt.Expected: every native request attempt should respect the shared pacing policy, including retries and overlapping query/grab workloads. Query/grab cooldown scopes can remain separate. This report does not propose lowering production intervals or changing aggregator-backed behavior.
Related PR2462 introduced scoped cooldown behavior and retained native pacing; these reproductions concern minimum-interval admission, not missing
Retry-Afterhandling. Discussion1667 concerns the wait timeout and is distinct.Steps to reproduce
On the revision below, put the test file at
internal/services/jackett/upstream_report_repro_test.go, then run:The 5-second interval is a test override using the existing
WithMinRequestIntervalhelper. These tests deliberately assert the current faulty behavior so they pass while demonstrating it; a fix should reverse those expectations.Self-contained reproduction using existing package test helpers
Environment
The production build has local cross-seed extensions. Current upstream was inspected separately; only the explicitly described isolated tests were run against that upstream revision. No production tracker was used by the reproductions.
Relevant logs
Relevant paths: scheduler admission, WaitForMinInterval, DownloadTorrent.
Checklist
All reactions