Skip to content

Add a customizable Classname parameter #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.7
Choose a base branch
from
Open

Add a customizable Classname parameter #66

wants to merge 1 commit into from

Conversation

capripot
Copy link

Give the ability to change default classname.

@adaniello
Copy link
Contributor

Very good! Maybe i would prefer not use template strings to have IE full compatibility.

@capripot
Copy link
Author

capripot commented Oct 3, 2018

@adaniello I used template strings since the dist version is processed through browserify that makes it backward compatible.

@capripot
Copy link
Author

capripot commented Oct 3, 2018

@baptistedonaux Would you have a bit of time to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capripot @adaniello