Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how the Render Buffers are used #8

Closed
sirpalee opened this issue Nov 14, 2019 · 1 comment · Fixed by #309
Closed

Refactor how the Render Buffers are used #8

sirpalee opened this issue Nov 14, 2019 · 1 comment · Fixed by #309
Assignees
@sirpalee
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
Sprint 20 Sprint 21

Comments

@sirpalee
Copy link
Contributor

sirpalee commented Nov 14, 2019 •
edited

Refactor the render buffer system:

  • Write to the render buffers directly and avoid intermediate storage.
  • Support custom AOVs with the type color3f.
  • Support LPEs.
  • Optimize writing to buffers to improve interactivity.

HdEmbree is a good example
This was referenced Nov 14, 2019
Closed
Closed
@sirpalee sirpalee added the enhancement New feature or request label Nov 14, 2019
@sirpalee sirpalee mentioned this issue Nov 15, 2019
Closed
@sirpalee sirpalee added the render delegate Related to the Arnold Render Delegate label Nov 29, 2019
@sirpalee sirpalee changed the title [Render Delegate] Write data directly to Render Buffers from the driver Write data directly to Render Buffers from the driver Nov 29, 2019
@jhodgson jhodgson mentioned this issue Feb 26, 2020
Merged
@sirpalee sirpalee added this to Needs triage in Ticket Triage via automation Mar 13, 2020
@sirpalee sirpalee changed the title Write data directly to Render Buffers from the driver Refactor how the Render Buffers are used Mar 13, 2020
@sirpalee sirpalee self-assigned this Mar 13, 2020
@sirpalee sirpalee removed this from Needs triage in Ticket Triage Mar 13, 2020
@sirpalee sirpalee added this to To do in Sprint 20 via automation Mar 13, 2020
@sirpalee sirpalee moved this from To do to In progress in Sprint 20 Mar 13, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 19, 2020
@sirpalee
Directly passing render buffers to the driver and replacing HdArnoldR…
bd0d8fc 
…enderBuffer. (broken)

Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 19, 2020
@sirpalee
Directly passing render buffers to the driver and replacing HdArnoldR…
800dabe 
…enderBuffer. (broken)

Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 20, 2020
@sirpalee
Changing more of the driver and buffer behavior. (broken)
cd4f1fb 
Autodesk#8
@sirpalee
Copy link
Contributor Author

sirpalee commented Mar 20, 2020 •
edited

As a solution for this ticket, I decided to rewrite the render buffer / render pass system, so that I can solve multiple issues at once. The pull request for this ticket will include a solution for #226 #4 #12 and #9 .

sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 23, 2020
@sirpalee
Copy bucket data if both components and the input format matches.
d975ebf 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 23, 2020
@sirpalee
Copy bucket data if both components and the input format matches.
cf2d4c8 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 23, 2020
@sirpalee
Setting up primvar definitions for more aov names.
825fe90 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 23, 2020
@sirpalee
Handling different component counts for AOV copies.
74cae0b 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 23, 2020
@sirpalee
Quick fix for the build issue with older USD versions.
0370f85 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 24, 2020
@sirpalee
Converting between different different types in the render buffer.
c0ebd62 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 24, 2020
@sirpalee
Removing implemented TODO.
1ee710a 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 26, 2020
@sirpalee
Adding support for USD 19.5 and blitting using the compositor when ao…
bd0c3de 
…v bindings are empty.

Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 26, 2020
@sirpalee
Only updating the compositor and the full screen shader if there are …
e1408d8 
…any updates.

Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 26, 2020
@sirpalee
Adding cmake module to find Google Test.
3600b55 
Autodesk#8
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
da49b45 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
eadf9b8 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
36b920b 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
2aea793 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
@sirpalee sirpalee mentioned this issue Mar 27, 2020
Merged
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
4ad0fb8 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
@kikou kikou added this to In progress in Sprint 21 Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
fbedc1f 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
ceb29f5 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 30, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
c6243bb 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
Sprint 21 automation moved this from In progress to Done Mar 30, 2020
sebastienblor pushed a commit that referenced this issue Mar 30, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled. (#309)
49afdf3 
Fixes #8
Fixes #9
Fixes #4
sebastienblor pushed a commit that referenced this issue Apr 7, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled. (#309)
18b62bc 
Fixes #8
Fixes #9
Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirpalee sirpalee

Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
No open projects
Sprint 20
  
In progress
Sprint 21
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewriting how render buffers and aborted renders are handled. sirpalee/arnold-usd
1 participant
@sirpalee