Initialize counters at zero #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 26, 2023 15:25
brettimus
force-pushed
the
initialize-counters-at-zero
branch
from
6a64577 to
4e01aa1
Compare
brettimus
changed the title
actualwitch
reviewed
Jun 28, 2023
actualwitch
reviewed
Jun 28, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
initialize_at_zeromethod to the Prometheus and OpenTelemetry trackers, which is called when a function is initially decorated. The changes include tests.This will allow tooling that connects to Prometheus to be able to tell which functions (and objectives!) are being tracked, even if those functions haven't been called since adding autometrics to the codebase.
Additionally, I removed old code that we won't be using anymore 🧹