Fix: approx usage in pytest as illuminated with pytest/9061 #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1391 +/- ##
===============================================
- Coverage 84.48% 84.41% -0.08%
===============================================
Files 146 146
Lines 11267 11267
Branches 1925 1925
===============================================
- Hits 9519 9511 -8
- Misses 1234 1241 +7
- Partials 514 515 +1 |
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading pytest now correctly gives error for incorrect usage of
pytest.approx. This was implemented in pytest #9061.