Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): fix input to quaternion #1933

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Sep 22, 2022

Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp

Description

The input to Eigen::Quaterniond is (w, x, y, z).

https://eigen.tuxfamily.org/dox/classEigen_1_1Quaternion.html#a3eba7a582f77a8f30525614821d7056f

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 10.28% // Head: 10.37% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (910ccb6) compared to base (1bbf9cd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
+ Coverage   10.28%   10.37%   +0.08%     
==========================================
  Files        1147     1141       -6     
  Lines       81946    75239    -6707     
  Branches    19035    18656     -379     
==========================================
- Hits         8429     7806     -623     
+ Misses      64396    58665    -5731     
+ Partials     9121     8768     -353     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.37% <ø> (+0.10%) ⬆️ Carriedforward from 8f1277f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...age_projection_based_fusion/src/utils/geometry.cpp 0.00% <ø> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-42.86%) ⬇️
system/default_ad_api/src/routing.cpp 0.00% <0.00%> (-37.50%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...wer/include/trajectory_follower/lowpass_filter.hpp 50.00% <0.00%> (-25.00%) ⬇️
...odel/vehicle_model_bicycle_kinematics_no_delay.cpp 70.00% <0.00%> (-21.31%) ⬇️
...mon/autoware_point_types/test/test_point_types.cpp 66.66% <0.00%> (-16.67%) ⬇️
... and 730 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 merged commit 6a5ac08 into autowarefoundation:main Sep 22, 2022
@yukke42 yukke42 deleted the fix-roi-object-fusion branch September 22, 2022 06:12
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
tzhong518 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 21, 2022
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
tzhong518 added a commit that referenced this pull request Oct 28, 2022
* feat: multiframe-pointpainting

Signed-off-by: tzhong518 <sworgun@gmail.com>

* ci(pre-commit): autofix

* fix: retrieve changes of classremap

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix(image_projection_based_fusion): fix input to quaternion (#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* add: launch files

Signed-off-by: tzhong518 <sworgun@gmail.com>

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
tzhong518 added a commit to tier4/autoware.universe that referenced this pull request Dec 9, 2022
…refoundation#2124)

* feat: multiframe-pointpainting

Signed-off-by: tzhong518 <sworgun@gmail.com>

* ci(pre-commit): autofix

* fix: retrieve changes of classremap

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* add: launch files

Signed-off-by: tzhong518 <sworgun@gmail.com>

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…refoundation#2124)

* feat: multiframe-pointpainting

Signed-off-by: tzhong518 <sworgun@gmail.com>

* ci(pre-commit): autofix

* fix: retrieve changes of classremap

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* add: launch files

Signed-off-by: tzhong518 <sworgun@gmail.com>

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants