Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(map_loader): split to member functions #1941

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 22, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

small refactoring for #1942

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 10.44% // Head: 10.44% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (40fdea4) compared to base (93cc9bd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
- Coverage   10.44%   10.44%   -0.01%     
==========================================
  Files        1233     1233              
  Lines       88034    88058      +24     
  Branches    20501    20501              
==========================================
  Hits         9197     9197              
- Misses      69328    69352      +24     
  Partials     9509     9509              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from 93cc9bd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Sep 22, 2022

@mitsudome-r @TakaHoribe @kenji-miyake Could you review?

The reason to split the implementation to some member functions is as follows. I will create a script which uses map_loader as a library and calls these member functions.
#1942

@takayuki5168 takayuki5168 marked this pull request as ready for review September 22, 2022 17:11
@takayuki5168 takayuki5168 marked this pull request as draft September 22, 2022 17:39
@takayuki5168 takayuki5168 marked this pull request as ready for review September 22, 2022 18:27
@kenji-miyake
Copy link
Contributor

kenji-miyake commented Sep 23, 2022

For future reviews, it's better to split these kinds of changes (removing this, use const, etc.) into a separate commit.
image

@takayuki5168
Copy link
Contributor Author

@kenji-miyake Thank you always for your quick review and also further review.

@takayuki5168 takayuki5168 merged commit 1279296 into autowarefoundation:main Sep 23, 2022
@takayuki5168 takayuki5168 deleted the refactor/map-loader branch September 23, 2022 10:18
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants