Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensor-rt): allow deprecated declarations for some tensorrt packages #2559

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 21, 2022

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

Part of: #2330

Until we upgrade the packages, we can allow deprecated declarations in CMakeLists.txt files of the respective packages.

# TODO(package_name): Remove once upgrading to TensorRT 8.5 is complete
add_compile_options(-Wno-deprecated-declarations)

I've compiled all with latest TensorRT 8.5 and it compiles fine. I've also checked the traffic_light_ssd_fine_detector and it seems to be working just fine in latest version.

Screenshot from 2022-12-21 20-22-21

I went for this quick fix because updating enqueueV2 to enqueueV3 was complicated for me, I didn't want to spend more time on it.

I was going to add updated and deprecated codes together like I did in #2325 but enqueueV3 part didn't work as I expected and I didn't want to spend more time on it.

This simple fix should be ok until someone with better experience can take on the rest of issues.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx requested review from wep21, a team, yukke42 and manato as code owners December 21, 2022 17:27
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Dec 21, 2022
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 21, 2022

cc @yukkysaito @kenji-miyake @wep21

@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 21, 2022

This is a very simple and non-destructive change PR, I'd appreciate if we can merge it soon.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 11.29% // Head: 10.99% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (9ecde3b) compared to base (9376697).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2559      +/-   ##
==========================================
- Coverage   11.29%   10.99%   -0.30%     
==========================================
  Files        1168     1220      +52     
  Lines       81842    84007    +2165     
  Branches    20938    20938              
==========================================
  Hits         9240     9240              
- Misses      62738    64903    +2165     
  Partials     9864     9864              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.29% <ø> (ø) Carriedforward from 9376697

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nterpoint/include/lidar_centerpoint/cuda_utils.hpp 0.00% <0.00%> (ø)
...rception/lidar_centerpoint/lib/centerpoint_trt.cpp 0.00% <0.00%> (ø)
...tion/tensorrt_yolo/lib/src/plugins/mish_plugin.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/nms_plugin.hpp 0.00% <0.00%> (ø)
...ption/tensorrt_yolo/lib/src/plugins/nms_plugin.cpp 0.00% <0.00%> (ø)
...on/lidar_centerpoint/src/single_inference_node.cpp 0.00% <0.00%> (ø)
...dar_centerpoint/lib/preprocess/voxel_generator.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolox/src/tensorrt_yolox.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
..._centerpoint/lib/postprocess/postprocess_kernel.cu 0.00% <0.00%> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx enabled auto-merge (squash) December 22, 2022 06:24
@xmfcx xmfcx disabled auto-merge December 22, 2022 11:20
@xmfcx xmfcx merged commit 14b8ee7 into main Dec 22, 2022
@xmfcx xmfcx deleted the allow-deprecated-trt branch December 22, 2022 11:21
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ges (autowarefoundation#2559)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants