Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_auto_common): move headers to a separate directory #5919

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix(autoware_auto_common): move headers to a separate directory #5919

merged 2 commits into from
Jan 9, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 19, 2023 •
edited by satoshi-ota

Description

This PR moves headers to a seaparate autoware_auto_common directory.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Dec 19, 2023
@esteve esteve mentioned this pull request Dec 19, 2023
Open
16 tasks
@esteve esteve force-pushed the autoware-auto-common-move-headers branch from 9d98964 to fa7e770 Compare December 20, 2023 14:02
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
@satoshi-ota
Copy link
Contributor

Hi @esteve Could you fix required CI fail...?

@esteve esteve marked this pull request as draft December 22, 2023 11:35
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5de111f) 15.23% compared to head (a282ca8) 15.23%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5919   +/-   ##
=======================================
  Coverage   15.23%   15.23%           
=======================================
  Files        1751     1755    +4     
  Lines      120918   120929   +11     
  Branches    36770    36773    +3     
=======================================
+ Hits        18419    18429   +10     
+ Misses      81825    81824    -1     
- Partials    20674    20676    +2
Flag Coverage Δ *Carryforward flag
differential 17.25% <ø> (?)
total 15.23% <ø> (ø) Carriedforward from 5de111f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve
Copy link
Contributor Author

esteve commented Dec 22, 2023

@satoshi-ota my apologies, I've fixed the errors in the latest commit. This PR is now ready for review.

@esteve esteve marked this pull request as ready for review December 22, 2023 14:39
@satoshi-ota
Copy link
Contributor

Hi @esteve I guessed #5941 caused some conflicts. Could you rebase or fix conficts...?

@esteve
fix(autoware_auto_common): move headers to a separate directory
8abb46a 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the autoware-auto-common-move-headers branch from ac41eae to 8abb46a Compare January 5, 2024 09:04
@esteve
Copy link
Contributor Author

esteve commented Jan 5, 2024

@satoshi-ota I've rebased this PR on top of main and fixed the conflicts, could you have a look at it again? Thanks.

@esteve esteve enabled auto-merge (squash) January 5, 2024 09:50
@esteve esteve merged commit af08c40 into main Jan 9, 2024
24 of 25 checks passed
@esteve esteve deleted the autoware-auto-common-move-headers branch January 9, 2024 05:06
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 10, 2024
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_common): move headers to a separate directory (auto…
b2e694f 
…warefoundation#5919)

* fix(autoware_auto_common): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_common): move headers to a separate directory (auto…
c67b032 
…warefoundation#5919)

* fix(autoware_auto_common): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_common): move headers to a separate directory (auto…
cf560cc 
…warefoundation#5919)

* fix(autoware_auto_common): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_common): move headers to a separate directory (auto…
e0f0be5 
…warefoundation#5919)

* fix(autoware_auto_common): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@tkimura4 tkimura4 tkimura4 approved these changes

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@esteve @satoshi-ota @tkimura4 @taikitanaka3 @maxime-clem