Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_auto_geometry): move headers to a separate directory #5941

Merged
merged 5 commits into from
Dec 26, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 22, 2023

Description

This PR moves headers to a directory that matches the name of the package.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 22, 2023
@esteve esteve added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 22, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 22, 2023
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
pre-commit-ci bot and others added 2 commits December 22, 2023 12:09
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e2f184) 15.28% compared to head (4db4dcf) 15.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5941      +/-   ##
==========================================
+ Coverage   15.28%   15.59%   +0.31%     
==========================================
  Files        1750     1762      +12     
  Lines      120432   121022     +590     
  Branches    36729    36950     +221     
==========================================
+ Hits        18404    18877     +473     
- Misses      81375    81398      +23     
- Partials    20653    20747      +94     
Flag Coverage Δ *Carryforward flag
differential 56.35% <ø> (?)
total 15.28% <ø> (ø) Carriedforward from 2e2f184

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve marked this pull request as ready for review December 22, 2023 15:08
@satoshi-ota satoshi-ota merged commit 719b733 into main Dec 26, 2023
26 of 27 checks passed
@satoshi-ota satoshi-ota deleted the autoware-auto-geometry-move-headers branch December 26, 2023 06:04
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…towarefoundation#5941)

* fix(autoware_auto_geometry): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix header name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix headers for CMake

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…towarefoundation#5941)

* fix(autoware_auto_geometry): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix header name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix headers for CMake

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…towarefoundation#5941)

* fix(autoware_auto_geometry): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix header name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix headers for CMake

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…towarefoundation#5941)

* fix(autoware_auto_geometry): move headers to a separate directory

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix header name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

* fix: fix headers for CMake

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants