Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): use update_bounds instead of update_lower/upper_bounds #6011

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 4, 2024

Description

When updating the bounds of QP with a warm start in the obstacle_avoidance_planner package, this PR uses osqp_update_bounds instead of osqp_update_lower/upper_bound.

According to the OSQP's implementation, the condition of whether the lower bound is smaller than the upper bound is checked in each osqp_upper_lower/upper_bound function.
Without this PR, since the lower and upper bounds are updated separately, when the lower bound is updated but the upper bound is not updated, the condition may not be met, resulting in the following printing many times.

[ERROR] upper bound must be greater than or equal to lower bound

In addition, in the latest version of OSQP's implementation, osqp_update_lower/upper_bound will be removed.
osqp/osqp#192

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…lower/upper_bounds

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 4, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 4, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 4, 2024 12:43
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed8ffea) 15.22% compared to head (66ea7cd) 15.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6011   +/-   ##
=======================================
  Coverage   15.22%   15.22%           
=======================================
  Files        1751     1751           
  Lines      120849   120848    -1     
  Branches    36721    36720    -1     
=======================================
  Hits        18398    18398           
+ Misses      81810    81809    -1     
  Partials    20641    20641           
Flag Coverage Δ *Carryforward flag
differential 36.46% <0.00%> (?)
total 15.22% <ø> (+<0.01%) ⬆️ Carriedforward from ed8ffea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit d02c165 into autowarefoundation:main Jan 5, 2024
37 of 39 checks passed
@takayuki5168 takayuki5168 deleted the fix/mpt-update-bounds branch January 5, 2024 07:36
yuki-takagi-66 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 5, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yuki-takagi-66 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
…lower/upper_bounds (autowarefoundation#6011) (#1253)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…lower/upper_bounds (autowarefoundation#6011)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants