Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(behavior_velocity_template_module): prefix package and namespace with autoware_ #6639

Merged
merged 14 commits into from
Jun 3, 2024
Merged

refactor(behavior_velocity_template_module): prefix package and namespace with autoware_ #6639

merged 14 commits into from
Jun 3, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 15, 2024 •
edited by xmfcx

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve added the DevOps Dojo: Build & Run Related to Open AD Kit WG label Mar 15, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 15, 2024
@esteve esteve added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) DevOps Dojo: Build & Run Related to Open AD Kit WG labels Mar 15, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 15, 2024
@esteve esteve mentioned this pull request Mar 27, 2024
Open
@esteve esteve force-pushed the prefix-behavior_velocity_template_module branch from 48e1be4 to 3b010b6 Compare March 27, 2024 14:58
@esteve esteve marked this pull request as draft March 27, 2024 16:39
@esteve esteve force-pushed the prefix-behavior_velocity_template_module branch 2 times, most recently from b229c53 to 4307fc1 Compare April 9, 2024 13:31
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Apr 10, 2024
@esteve esteve marked this pull request as ready for review April 10, 2024 12:39
@esteve esteve enabled auto-merge (squash) April 10, 2024 12:39
@esteve
Copy link
Contributor Author

esteve commented Apr 10, 2024

@danielsanchezaran @xmfcx @mitsudome-r this is now ready for review. I've also updated the code so that clang-tidy doesn't complain anymore.

auto-merge was automatically disabled April 24, 2024 15:24

Pull Request is not mergeable

@esteve
Copy link
Contributor Author

esteve commented May 7, 2024

Back to draft because I'm going to rename folders and move headers to a separate folder (see autowarefoundation/autoware#4569 (comment))

@esteve esteve marked this pull request as draft May 7, 2024 12:47
@esteve esteve force-pushed the prefix-behavior_velocity_template_module branch from 493ca06 to 6973420 Compare May 9, 2024 13:18
@esteve esteve marked this pull request as ready for review May 9, 2024 13:18
@esteve
Copy link
Contributor Author

esteve commented May 9, 2024

@xmfcx @mitsudome-r I've renamed the base folder, this is now ready for review. Thanks!

xmfcx
xmfcx approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this package is not used as it is, it is used as a template to create new modules.

And with these changes, it compiles correctly.

And because nothing depends on it, it should be alright to merge it.

@xmfcx
Copy link
Contributor

xmfcx commented May 9, 2024

@danielsanchezaran please review it too 🙇 , I will merge this by tomorrow.

@xmfcx
Copy link
Contributor

xmfcx commented May 10, 2024

Similar to #6693 (review):

Needs to be updated.
cc. @maxime-clem

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label May 13, 2024
@xmfcx xmfcx changed the title build(behavior_velocity_template_module): prefix package and namespace with autoware_ refactor(behavior_velocity_template_module)!: prefix package and namespace with autoware_ May 27, 2024
@xmfcx
Copy link
Contributor

xmfcx commented May 27, 2024

Could you rebase to latest main and fix the conflicts?

esteve and others added 14 commits May 27, 2024 14:50
@esteve
build(behavior_velocity_template_module): prefix package and namespac…
a77ef63 
…e with autoware_

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
92102fa 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: fix namespace
86cdbd4 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(autoware_behavior_velocity_template_module): fix namespace
64ad7fc 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
e7fb451 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix(autoware_velocity_template_module): fix clang-tidy issues
11a4d3b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(autoware_behavior_velocity_template_module): fix variable name
1bf87db 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix(autoware_behavior_velocity_template_module): fix clang-tidy issues
e55d19b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
33c252c 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix(autoware_behavior_velocity_template_module): fix tests
52edd6b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: missing renames
9792cd9 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(autoware_behavior_velocity_template_module): prefix base folder…
ce79e54 
… with autoware_

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: added prefix to missing strings
dc2c6c0 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: update commented out dependency
b08a173 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-behavior_velocity_template_module branch from fe23a28 to b08a173 Compare May 27, 2024 12:51
@esteve
Copy link
Contributor Author

esteve commented May 27, 2024

@xmfcx done, this branch had conflicts after #6693 was merged

@esteve esteve enabled auto-merge (squash) May 27, 2024 15:29
@esteve esteve changed the title refactor(behavior_velocity_template_module)!: prefix package and namespace with autoware_ refactor(behavior_velocity_template_module): prefix package and namespace with autoware_ May 29, 2024
@xmfcx xmfcx disabled auto-merge June 3, 2024 08:08
@xmfcx xmfcx merged commit 25cf700 into main Jun 3, 2024
24 of 25 checks passed
@xmfcx xmfcx deleted the prefix-behavior_velocity_template_module branch June 3, 2024 08:08
@esteve
Copy link
Contributor Author

esteve commented Jun 3, 2024

@xmfcx @danielsanchezaran @takayuki5168 thank you all for your reviews 🙂

a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@esteve @a-maumau
refactor(behavior_velocity_template_module): prefix package and names…
0706061 
…pace with autoware_ (autowarefoundation#6639)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@danielsanchezaran danielsanchezaran danielsanchezaran approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@xmfcx xmfcx Awaiting requested review from xmfcx

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@mkuri mkuri Awaiting requested review from mkuri

@soblin soblin Awaiting requested review from soblin

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees

@esteve esteve

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@esteve @xmfcx @takayuki5168 @danielsanchezaran