Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(behavior_velocity_planner)!: prefix package and namespace with autoware_ #6693

Merged
merged 53 commits into from
May 27, 2024
Merged

refactor(behavior_velocity_planner)!: prefix package and namespace with autoware_ #6693

merged 53 commits into from
May 27, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 27, 2024 •
edited by xmfcx
Loading

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 27, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 27, 2024
@esteve esteve changed the title build(behavior_velocity_planner): build(static_centerline_optimizer): prefix package and namespace with autoware_ build(behavior_velocity_planner): prefix package and namespace with autoware_ Mar 27, 2024
@esteve esteve force-pushed the prefix-behavior_velocity_planner branch from d743317 to 4e686b1 Compare March 27, 2024 15:09
@esteve esteve mentioned this pull request Mar 27, 2024
Open
@esteve esteve marked this pull request as draft March 27, 2024 16:39
@esteve esteve force-pushed the prefix-behavior_velocity_planner branch 2 times, most recently from 49f86e2 to d275517 Compare April 2, 2024 13:35
@esteve esteve force-pushed the prefix-behavior_velocity_planner branch from 798be97 to 7e375bc Compare April 9, 2024 14:24
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Apr 12, 2024
@esteve esteve force-pushed the prefix-behavior_velocity_planner branch from 1fc5e81 to 630942e Compare April 12, 2024 15:46
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Apr 12, 2024
esteve and others added 17 commits May 24, 2024 13:43
@esteve
build(autoware_behavior_velocity_planner): rename base directory for …
4f4c498 
…autoware_behavior_velocity_planner

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: added prefix to missing strings
aea6f53 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
5214696 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve @xmfcx
Update planning/autoware_behavior_velocity_planner/launch/behavior_ve…
73c60b3 
…locity_planner.launch.xml

Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: fix namespaces
a98d97a 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: use correct PluginInterface namespace
79963a2 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: revert clang-tidy related changes
71b8f5b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: prefix all plugins and behavior_velocity_planner_common
4ff7b65 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: update PluginInterface namespace
61b2d70 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: revert changes to behavior_velocity_planner
72c3739 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: only rename the folder, not the package
5a40e4a 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: fix package.xml dependencies
880862a 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: behavior_velocity_planner package renamed to autoware_behav…
6f66fcf 
…ior_velocity_planner . BehaviorVelocityPlannerNode loads, but plugins do not.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor: update plugins export
70db5f7 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
refactor(autoware_behavior_velocity_planner): move code to autoware::…
e4273ee 
…behavior_velocity_planner namespace

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
3d98f31 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: fix package name
f8b4cb6 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-behavior_velocity_planner branch from 294c6cf to f8b4cb6 Compare May 24, 2024 11:44
@esteve
Copy link
Contributor Author

esteve commented May 24, 2024

@xmfcx thanks, I've pushed the fix in f8b4cb6

@esteve esteve enabled auto-merge (squash) May 24, 2024 11:44
@xmfcx
Copy link
Contributor

xmfcx commented May 27, 2024

@esteve I will rename the PR title to refactor() instead of build() since this is a heavy refactoring task. But other than that, I've tested it and it works well. Thanks for the efforts.

@xmfcx xmfcx changed the title build(behavior_velocity_planner): prefix package and namespace with autoware_ refactor(behavior_velocity_planner): prefix package and namespace with autoware_ May 27, 2024
@xmfcx xmfcx disabled auto-merge May 27, 2024 09:34
@xmfcx xmfcx changed the title refactor(behavior_velocity_planner): prefix package and namespace with autoware_ refactor(behavior_velocity_planner)!: prefix package and namespace with autoware_ May 27, 2024
@xmfcx xmfcx merged commit 177db15 into main May 27, 2024
26 of 27 checks passed
@xmfcx xmfcx deleted the prefix-behavior_velocity_planner branch May 27, 2024 09:36
@esteve
Copy link
Contributor Author

esteve commented May 27, 2024

@xmfcx thanks for your feedback and the patience 🙂

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@esteve @karishma1911
refactor(behavior_velocity_planner)!: prefix package and namespace wi…
196de8a 
…th autoware_ (autowarefoundation#6693)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@esteve @a-maumau
refactor(behavior_velocity_planner)!: prefix package and namespace wi…
1acb214 
…th autoware_ (autowarefoundation#6693)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@esteve @KhalilSelyan
refactor(behavior_velocity_planner)!: prefix package and namespace wi…
0b6857c 
…th autoware_ (#6693)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem left review comments

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@mehmetdogru mehmetdogru Awaiting requested review from mehmetdogru

@ahmeddesokyebrahim ahmeddesokyebrahim Awaiting requested review from ahmeddesokyebrahim

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66

@xmfcx xmfcx Awaiting requested review from xmfcx

Assignees

@esteve esteve

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Autoware Labs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esteve @xmfcx @satoshi-ota @maxime-clem