Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append morai_msgs package related to testing codes about checking simulator compatibility #2739

Closed
3 tasks done
Soohyeok-Park opened this issue Jul 15, 2022 · 1 comment
Closed
3 tasks done
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@Soohyeok-Park
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

The pull request (PR link) has been approved but it fails to proceed due to the dependency of the package, morai_msgs.
At first, the morai_msgs package was in [autoware.universe/tools/simulator_test/]. but in the simulation working group, it was decided to remove it and then, append it to autoware.repos to maintain consistency with other packages.

Purpose

Since the pull request (PR link) has been approved but failed to be built, the morai_msgs package would be added to autoware.repos for further steps.

Possible approaches

None.

Definition of done

the morai_msgs package is listed on the autoware.repos.

@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Jul 27, 2022
@xmfcx
Copy link
Contributor

xmfcx commented Nov 16, 2023

Closing since:

And it is still present:

autoware/autoware.repos

Lines 36 to 39 in c9c4546

universe/external/morai_msgs:
type: git
url: https://github.com/MORAI-Autonomous/MORAI-ROS2_morai_msgs.git
version: main

@xmfcx xmfcx closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

3 participants