Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cmake cleanup #1156

Merged
merged 36 commits into from Apr 17, 2018
Merged

Fix/cmake cleanup #1156

merged 36 commits into from Apr 17, 2018

Conversation

amc-nu
Copy link
Member

@amc-nu amc-nu commented Mar 14, 2018 •
edited by kfunaoka

Status

PRODUCTION / DEVELOPMENT

Description

First try to fix CMakeLists on all packages. So far rosdep works correctly and no warnings nor errors occur.

A deeper analysis for each package is still required. There are many custom commands used that could be replaced by standard cmake commands.

autowarefoundation/autoware_ai#86 autowarefoundation/autoware_ai#61 autowarefoundation/autoware_ai#964 autowarefoundation/autoware_ai#960

This PR is still not adding the commands required to install or release packages.

Todos

  • Tested on Ubuntu 14.04 and Ubuntu 16.04
  • Documentation

Steps to Test or Reproduce

  1. Checkout this branch
  2. Run rosdep rosdep install --from-paths src --ignore-src -r -y This will install all the required dependencies for all packages to build correctly.
  3. compile ./catkin_make_release

Build Status

@amc-nu amc-nu requested a review from dejanpan March 14, 2018 03:01
@amc-nu amc-nu mentioned this pull request Mar 26, 2018
Closed
1 task
amc-nu added 24 commits April 2, 2018 14:12
@amc-nu
Merge branch 'develop' into fix/cmake_cleanup
ea1a9e1
@amc-nu
kf cjeck
575874d
@amc-nu
Merge branch 'develop' into fix/cmake_cleanup
9ba9c61 
Conflicts:
	ros/src/computing/perception/detection/packages/road_wizard/CMakeLists.txt
@amc-nu
Merge branch 'fix/cmake_cleanup' of https://github.com/CPFL/Autoware …
b168501 
…into fix/cmake_cleanup
@amc-nu
Fix road wizard
4102041
@amc-nu
Added travis ci
2030151
@amc-nu
Trigger CI
bc1cc09
@amc-nu
Fixes to cv_tracker and lidar_tracker cmake
b178f7d
@amc-nu
Fix kitti player dependencies
e9b3a6e
@amc-nu
Removed unnecessary dependencies
75fa3ef
@amc-nu
messages fixing for can
0af2b00
@amc-nu
Update build script travis
2724a8a
@amc-nu
Travis Path
77b8ae3
@amc-nu
Travis Paths fix
30a392f
@amc-nu
Travis test
6d4f527
@amc-nu
Eigen checks
8b27335
@amc-nu
removed unnecessary dependencies
2d49cc9
@amc-nu
Eigen Detection
bea231f
@amc-nu
Job number reduced
c999e85
@amc-nu
Eigen3 more fixes
b20a6a5
@amc-nu
More Eigen3
4a6df7c
@amc-nu
Even more Eigen
5e51436
@amc-nu
find package cmake modules included
e83bbac
@amc-nu
More fixes to cmake modules
92c568a
@amc-nu amc-nu requested a review from aohsato April 15, 2018 05:04
@yk-fujii
Copy link

@amc-nu
Great work!
I tested it on kinetic with 16.04.
I found missing dependencies for some package's package.xml there are following:

  • pos_db
    libssh2-dev
  • openplanner
    libglew-dev
  • calibration toolkit
    nlopt => libnlopt-dev
  • lattice_planner
    armadillo

Could you fix it?

Also, I got a following error, but this is not a problem.

ERROR: the following rosdeps failed to install
  apt: command [sudo -H apt-get install -y libxerces-c2-dev] failed
  apt: Failed to detect successful installation of [libxerces-c2-dev]

I think it is a bug on the ROS side.
libxerces-c2-dev only exist in trusty (14.04), xenial's package is libxerces-c-dev
https://packages.ubuntu.com/trusty/libdevel/libxerces-c2-dev
But, libxerces-c2-dev is registered for ubuntu in rodep's yaml.
https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L4894
However, since libxerces-c-dev is installed with ros-kinetic-desktop-full dependency, it is OK to build autoware.

@amc-nu
Copy link
Member Author

amc-nu commented Apr 15, 2018

@yk-fujii thanks for your feedback.
I’ll check it and push the fix.

yk-fujii
yk-fujii approved these changes Apr 16, 2018
View reviewed changes
Copy link

@yk-fujii yk-fujii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@yk-fujii
Copy link

@aohsato @kitsukawa @kfunaoka Please test this PR.

@yk-fujii yk-fujii requested a review from kfunaoka April 16, 2018 14:00
@dejanpan
Copy link

@amc-nu: are you guys merging this with #1218?

@amc-nu
Copy link
Member Author

amc-nu commented Apr 16, 2018

@sumanth-nirmal @dejanpan indeed. I'm going to bring #1218 changes to this one. specially for the install part. Thanks so much for your work on this, it is invaluable.
I'm also integrating https://github.com/ros-industrial/industrial_ci

@dejanpan
Copy link

super sorry for not being able to help more.

@amc-nu amc-nu merged commit 1aec712 into develop Apr 17, 2018
@amc-nu amc-nu deleted the fix/cmake_cleanup branch April 17, 2018 05:57
@amc-nu amc-nu mentioned this pull request Apr 17, 2018
Closed
@amc-nu amc-nu mentioned this pull request Apr 27, 2018
Merged
2 tasks
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@amc-nu
Fix/cmake cleanup (autowarefoundation#1156)
1a332a4 
* Initial Cleanup

* fixed also for indigo

* kf cjeck

* Fix road wizard

* Added travis ci

* Trigger CI

* Fixes to cv_tracker and lidar_tracker cmake

* Fix kitti player dependencies

* Removed unnecessary dependencies

* messages fixing for can

* Update build script travis

* Travis Path

* Travis Paths fix

* Travis test

* Eigen checks

* removed unnecessary dependencies

* Eigen Detection

* Job number reduced

* Eigen3 more fixes

* More Eigen3

* Even more Eigen

* find package cmake modules included

* More fixes to cmake modules

* Removed non ros dependency

* Enable industrial_ci for indidog and kinetic

* Wrong install command

* fix rviz_plugin install

* FastVirtualScan fix

* Fix Qt5 Fastvirtualscan

* Fixed qt5 system dependencies for rosdep

* NDT TKU Fix catkin not pacakged

* Fixes from industrial_ci
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk-fujii yk-fujii yk-fujii approved these changes

@kitsukawa kitsukawa kitsukawa approved these changes

@dejanpan dejanpan Awaiting requested review from dejanpan

@aohsato aohsato Awaiting requested review from aohsato

@kfunaoka kfunaoka Awaiting requested review from kfunaoka

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amc-nu @yk-fujii @dejanpan @kitsukawa @mitsudome-r