Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixes for all packages and dependencies #1240

Merged
merged 99 commits into from
May 8, 2018
Merged

Conversation

amc-nu
Copy link
Member

@amc-nu amc-nu commented Apr 27, 2018

Status

PRODUCTION / DEVELOPMENT

Description

  • Fixed all the packages for its release.
  • Cleaned dependencies.
  • Added travis configuration for indigo and kinetic.

Related PRs

#1156 #1218

Todos

  • Tests
  • Documentation

# Conflicts:
#	.travis.yml
#	ros/src/computing/perception/detection/lib/fusion/package.xml
#	ros/src/computing/perception/detection/lib/image/kf/CMakeLists.txt
#	ros/src/computing/perception/detection/lib/image/librcnn/CMakeLists.txt
#	ros/src/computing/perception/detection/lib/libvectormap/CMakeLists.txt
#	ros/src/computing/perception/detection/lib/libvectormap/package.xml
#	ros/src/computing/perception/detection/packages/cv_tracker/CMakeLists.txt
#	ros/src/computing/perception/detection/packages/cv_tracker/package.xml
#	ros/src/computing/perception/detection/packages/integrated_viewer/package.xml
#	ros/src/computing/perception/detection/packages/lidar_tracker/CMakeLists.txt
#	ros/src/computing/perception/detection/packages/road_wizard/CMakeLists.txt
#	ros/src/computing/perception/detection/packages/road_wizard/package.xml
#	ros/src/computing/perception/detection/packages/viewers/package.xml
#	ros/src/computing/perception/localization/lib/fast_pcl/ndt_cpu/CMakeLists.txt
#	ros/src/computing/perception/localization/lib/fast_pcl/ndt_cpu/package.xml
#	ros/src/computing/perception/localization/lib/fast_pcl/ndt_gpu/CMakeLists.txt
#	ros/src/computing/perception/localization/lib/fast_pcl/ndt_gpu/package.xml
#	ros/src/computing/perception/localization/lib/ndt_tku/CMakeLists.txt
#	ros/src/computing/perception/localization/lib/ndt_tku/package.xml
#	ros/src/computing/perception/localization/packages/icp_localizer/CMakeLists.txt
#	ros/src/computing/perception/localization/packages/ndt_localizer/CMakeLists.txt
#	ros/src/computing/perception/localization/packages/ndt_localizer/package.xml
#	ros/src/computing/perception/localization/packages/orb_localizer/CMakeLists.txt
#	ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/CMakeLists.txt
#	ros/src/computing/perception/localization/packages/orb_localizer/package.xml
#	ros/src/computing/perception/semantics/packages/object_map/CMakeLists.txt
#	ros/src/computing/planning/common/lib/openplanner/op_simu/CMakeLists.txt
#	ros/src/computing/planning/decision/libs/libamathutils/CMakeLists.txt
#	ros/src/computing/planning/decision/libs/libstate/CMakeLists.txt
#	ros/src/computing/planning/decision/packages/decision_maker/CMakeLists.txt
#	ros/src/computing/planning/mission/packages/lane_planner/CMakeLists.txt
#	ros/src/computing/planning/motion/packages/lattice_planner/package.xml
#	ros/src/computing/planning/motion/packages/op_simulator_perception/CMakeLists.txt
#	ros/src/computing/planning/motion/packages/waypoint_maker/CMakeLists.txt
#	ros/src/data/packages/obj_db/CMakeLists.txt
#	ros/src/data/packages/pos_db/CMakeLists.txt
#	ros/src/data/packages/vector_map_server/CMakeLists.txt
#	ros/src/sensing/filters/packages/points_preprocessor/package.xml
#	ros/src/sensing/fusion/packages/calibration_camera_lidar/CMakeLists.txt
#	ros/src/sensing/fusion/packages/calibration_camera_lidar/package.xml
#	ros/src/sensing/fusion/packages/points2image/CMakeLists.txt
#	ros/src/sensing/fusion/packages/points2image/package.xml
#	ros/src/sensing/fusion/packages/scan2image/CMakeLists.txt
#	ros/src/sensing/polygon/packages/points2polygon/package.xml
#	ros/src/socket/packages/mqtt_socket/CMakeLists.txt
#	ros/src/socket/packages/tablet_socket/CMakeLists.txt
#	ros/src/system/gazebo/catvehicle/CMakeLists.txt
#	ros/src/system/gazebo/catvehicle/package.xml
#	ros/src/util/packages/RobotSDK/glviewer/package.xml
#	ros/src/util/packages/requirements_version_checker/CMakeLists.txt
#	ros/src/util/packages/sample_data/CMakeLists.txt
#	ros/src/util/packages/sample_data/package.xml
@yk-fujii
Copy link

yk-fujii commented May 2, 2018

I resolved conflict by my PR #1191 .

@@ -1,40 +1,49 @@
cmake_minimum_required(VERSION 2.8.3)
project(as)

# If submodule is not cloned this project will not be build.
set(AS_MSG_PATH "${CMAKE_SOURCE_DIR}/msgs/platform_automation_msgs/module_comm_msgs")
if(EXISTS "${AS_MSG_PATH}")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this IF statement always makes catkin search for module_comm_msgs.
So, I got error:

-- Could not find the required component 'module_comm_msgs'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
  Could not find a package configuration file provided by "module_comm_msgs"
  with any of the following names:

    module_comm_msgsConfig.cmake
    module_comm_msgs-config.cmake

  Add the installation prefix of "module_comm_msgs" to CMAKE_PREFIX_PATH or
  set "module_comm_msgs_DIR" to a directory containing one of the above
  files.  If "module_comm_msgs" provides a separate development package or
  SDK, be sure it has been installed.
Call Stack (most recent call first):
  actuation/vehicles/packages/as/CMakeLists.txt:4 (find_package)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing the as submodule.
Please run:
git submodule update --init --recursive

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know to need git submodule update --init --recursive
But, I think that autoware does not necessarily need to compile "as" package because problems often occur frequently by not executing this command.

If you want to use "as" default, I think that you need to include this command in catkin_make_release, install manual, or etc.
How about you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then if this package is not needed I recommend to add a CATKIN_IGNORE

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amc-nu
Copy link
Member Author

amc-nu commented May 2, 2018

@yk-fujii thanks for fixing the conflict!

@yk-fujii
Copy link

yk-fujii commented May 8, 2018

@kfunaoka @aohsato @kitsukawa
Please review :)

@amc-nu amc-nu merged commit 0a48443 into develop May 8, 2018
@amc-nu amc-nu deleted the feature/industrial_ci branch May 10, 2018 02:42
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
* Initial Cleanup

* fixed also for indigo

* kf cjeck

* Fix road wizard

* Added travis ci

* Trigger CI

* Fixes to cv_tracker and lidar_tracker cmake

* Fix kitti player dependencies

* Removed unnecessary dependencies

* messages fixing for can

* Update build script travis

* Travis Path

* Travis Paths fix

* Travis test

* Eigen checks

* removed unnecessary dependencies

* Eigen Detection

* Job number reduced

* Eigen3 more fixes

* More Eigen3

* Even more Eigen

* find package cmake modules included

* More fixes to cmake modules

* Removed non ros dependency

* Enable industrial_ci for indidog and kinetic

* Wrong install command

* fix rviz_plugin install

* FastVirtualScan fix

* Fix Qt5 Fastvirtualscan

* Fixed qt5 system dependencies for rosdep

* NDT TKU Fix catkin not pacakged

* More in detail dependencies fixes for more packages

* GLEW library for ORB

* Ignore OrbLocalizer

* Ignore Version checker

* Fix for driveworks interface

* driveworks not catkinpackagedd

* Missing catkin for driveworks

* libdpm opencv not catkin packaged

* catkin lib gnss  not included in obj_db

* Points2Polygon fix

* More missing dependencies

* image viewer not packaged

* Fixed SSH2 detection, added viewers for all distros

* Fix gnss localizer incorrect dependency config

* Fixes to multiple packages dependencies

* gnss plib and package

* More fixes to gnss

* gnss dependencies for gnss_loclaizer

* Missing gnss dependency for gnss on localizer

* More fixes for dependencies
Replaced gnss for autoware_gnss_library

* gnss more fixes

* fixes to more dependencies

* header dependency

* Debug message

* more debug messages changed back to gnss

* debud messages

* gnss test

* gnss install command

* Several fixes for OpenPlanner and its lbiraries

* Fixes to ROSInterface

* More fixes to robotsdk and rosinterface

* robotsdk calibration fix

* Fixes to rosinterface robotsdk libraries and its nodes

* Fixes to Qt5 missing dependencies in robotsdk

* glviewer missing dependencies

* Missing qt specific config cmake for robotsdk

* disable cv_tracker

* Fix to open planner un needed dependendecies

* Fixes for libraries indecision maker

* Fixes to libraries decision_maker installation

* Gazebo on Kinetic

* Added Missing library

* * Removed Gazebo and synchonization packages
* Renames vmap in lane_planner
* Added installation commands for missing pakcages

* Fixes to lane_planner

* Added NDT TKU Glut extra dependencies

* ndt localizer/lib fast pcl fixes
re enable cv_tracker

* Fix kf_lib

* Keep industrial_ci

* Fixes for dpm library

* Fusion lib fixed

* dpm and fusion header should match exported project name

* Fixes to dpm_ocv  ndt_localizer and pcl_omp

* no fast_pcl anymore

* fixes to libdpm and its package

* CI test

* test with native travis ci

* missing update for apt

* Fixes to pcl_omp installation and headers

* Final fixes for tests, modified README

* * Fixes to README
* Enable industrial_ci

* re enable native travis tests
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants