Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Manager, modify update_func() #806

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

kondoh2
Copy link

@kondoh2 kondoh2 commented Sep 21, 2017

Status

PRODUCTION / DEVELOPMENT

Description

Correct processing when parameter is not set when Runtime Manager node is started

When Runtime Manager starts the node,
When the parameter is not set,
Fix processing to complement the default value.

Conventionally, among a plurality of parameters given to a node,
Only when all are not set up, we supplemented all default values.

Among the plurality of parameters to be given to the node,
Even if only a part of it is not set,
It complemented the default value.

With this change,
When adding a parameter to a node,
Even if the old param.yaml remains,
Default values will be set for new parameters added.

英文が不適当かもしれませんので、以下、日本語で失礼します。

Runtime Managerのノード起動時にパラメータが未設定の場合の処理の修正

Runtime Managerがノードを起動する際に、
パラメータが未設定の場合に、
デフォルト値を補完する処理を修正しました。

従来では、ノードに与える複数のパラメータのうち、
全てが未設定な場合のみ、全てにデフォルト値を補完していました。

ノードに与える複数のパラメータのうち、
一部だけが未設定な場合でも、該当パラメータに
デフォルト値を補完するようにしました。

この変更により、
ノードにパラメータの追加を行なった時に、
古いparam.yamlが残っている場合でも、
追加した新しいパラメータにデフォルト値が設定されるようになります。

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

roslaunch pkg_A executable_A

The car should move.

@yk-fujii
Copy link

Please describe purpose and change overview according to the template.

@kondoh2
Copy link
Author

kondoh2 commented Sep 21, 2017

Sorry, I added description.

@yk-fujii
Copy link

Thanks!
I've confirmed. please merge it.

@kondoh2 kondoh2 merged commit c9fbe5b into develop Sep 21, 2017
@kondoh2 kondoh2 deleted the feature/runtime_manager_fix_update branch September 21, 2017 03:48
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants