Runtime Manager, modify update_func() #806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
PRODUCTION / DEVELOPMENT
Description
Correct processing when parameter is not set when Runtime Manager node is started
When Runtime Manager starts the node,
When the parameter is not set,
Fix processing to complement the default value.
Conventionally, among a plurality of parameters given to a node,
Only when all are not set up, we supplemented all default values.
Among the plurality of parameters to be given to the node,
Even if only a part of it is not set,
It complemented the default value.
With this change,
When adding a parameter to a node,
Even if the old param.yaml remains,
Default values will be set for new parameters added.
英文が不適当かもしれませんので、以下、日本語で失礼します。
Runtime Managerのノード起動時にパラメータが未設定の場合の処理の修正
Runtime Managerがノードを起動する際に、
パラメータが未設定の場合に、
デフォルト値を補完する処理を修正しました。
従来では、ノードに与える複数のパラメータのうち、
全てが未設定な場合のみ、全てにデフォルト値を補完していました。
ノードに与える複数のパラメータのうち、
一部だけが未設定な場合でも、該当パラメータに
デフォルト値を補完するようにしました。
この変更により、
ノードにパラメータの追加を行なった時に、
古いparam.yamlが残っている場合でも、
追加した新しいパラメータにデフォルト値が設定されるようになります。
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
The car should move.