Diagnostic signs remain in the gutter after fixing all errors

[kodemeister]

Hi @autozimu,

I'm having erroneous diagnostic signs even after I fix all syntax errors in C++ code. If I move cursor to the line containing the sign, I don't see any error messages in the status line. Logs also show that the language server returns an empty list in textDocument/publishDiagnostics message. So I believe it's purely displaying issue.

• neovim/vim version: NVIM v0.2.2
• Plugin version (git SHA): ed183d7
• Minimal vimrc:

call plug#begin('~/.config/nvim/plugged')

Plug 'autozimu/LanguageClient-neovim', {
    \ 'branch': 'next',
    \ 'do': 'bash install.sh',
    \ }

call plug#end()

let g:LanguageClient_serverCommands = {
    \ 'cpp': ['clangd'],
    \ }
let g:LanguageClient_loggingLevel = 'DEBUG'

• Language server name/link and version: latest clangd 7 from SVN. BTW stable clangd 5 doesn't work for me at all (probably due to clangd completion does not work #72 reintroduced in new rust implementation) but this is another story.
• Reproduction steps (from clean state):

1. Open the following C++ file with a syntax error:

#include <iostream>

void foo()
{

int main(int argc, char **argv)
{
	return 0;
}

2. See the diagnostic signs because of missing closing brace.
3. Fix the error by adding the missing brace to line 5.

Expected: all diagnostic signs disappear.
Observed: erroneous diagnostic signs still remain in the gutter.

This issue happens only in next branch. Legacy python implementation works correctly.

• Logs.
  LanguageClient.log
  LanguageServer.log

Thank you for your hard work!

[KillTheMule]

I can confirm this, using rls and a more recent neovim. I'm using :sign unplace * as a workaround, since I have a binding to clear various visuals anyways.

[JulioJu]

Same with TypeScript or JavaScript projects.

[nwoeanhinnogaehr]

A quick bisect reveals this was introduced in 2c56c54

[YaLTeR]

Not sure if related, but when working with RLS on the latest git of LanguageClient_neovim I sometimes get gutter signs that are one line off (so the actual errors are on a line right next to the gutter sign, and the error messages show up on the correct lines), and sometimes I get gutter signs where there are seemingly no errors (moving the cursor there doesn't make any error messages show up).

[dsifford]

Ran into this today with typescript. Has this been fixed? Anybody else still getting this?

[garymjr]

I just started using this plugin and found I am I also experiencing this issue with javascript/typescript.

[languitar]

I also still have signs and highlights that remain forever. Might this be a race condition with other plugins that handle the gutter?

[languitar]

Also see #295

[XiaowenHu96]

I'm having this with Haskell (hie-wrapper), C++(clangd) and Python (pyls).
Is anyone still having this?

[theimpostor]

I am still seeing this, I opened a new issue #1008 with details

[gurditsbedi]

I also experiencing this issue with python3.6 (pyls server) and c (clangd-8 server).