Skip to content

Conversation

samliok
Copy link
Collaborator

@samliok samliok commented Oct 2, 2025

  1. we are building a block
  2. while we build a block we get an empty notarization
    a .we increase the round,
    b. the block builder gets cancelled
    c. we call monitorProgress on the new round when we enter startRound
  3. we call the monitorProgress in the buildBlock task after. this would cancel the current monitorProgress and monitors a stale round

therefore we should check if the round has increased while building a block and not call monitorProgress() if so

@yacovm
Copy link
Collaborator

yacovm commented Oct 6, 2025

#267 has a test :)

@yacovm yacovm closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants