-
Notifications
You must be signed in to change notification settings - Fork 807
Cubesigner keychain #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felipemadero
wants to merge
17
commits into
master
Choose a base branch
from
cubesigner-keychain-on-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cubesigner keychain #4277
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
03a86c3
Add CubeSigner keychain integration
felipemadero 89fa84d
Add key type validation to processKey function to ensure only support…
felipemadero dde6d27
Update copyright headers to 2019-2025
felipemadero 2ba5613
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero 753a25d
lint
felipemadero 3da2018
license lint
felipemadero 62f91fa
Merge branch 'master' into cubesigner-keychain-on-master
yacovm 0f6dd6a
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero 8c47233
Address PR comments
felipemadero 158faf1
Add godoc comments and unit tests for ledger Sign method
felipemadero c480d7a
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero 2eb5ee3
Fix P chain wallet signer integration
felipemadero 0bb65bc
Remove force sign hash wallet option to reduce PR scope
felipemadero 0de0c8f
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero 8d68829
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero e30b4a1
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero 5bb4caa
Merge branch 'master' into cubesigner-keychain-on-master
felipemadero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package cubesigner | ||
|
|
||
| import ( | ||
| "github.com/cubist-labs/cubesigner-go-sdk/client" | ||
| "github.com/cubist-labs/cubesigner-go-sdk/models" | ||
| ) | ||
|
|
||
| // CubeSignerClient defines the interface for CubeSigner client operations | ||
| // needed by the keychain implementation | ||
| type CubeSignerClient interface { | ||
| // GetKeyInOrg retrieves key information for the given keyID from the CubeSigner organization. | ||
| // It returns the key metadata, including public key and key type. | ||
| GetKeyInOrg(keyID string) (*models.KeyInfo, error) | ||
felipemadero marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // BlobSign signs arbitrary data using the specified keyID. | ||
| // request contains the data to be signed. | ||
| BlobSign(keyID string, request models.BlobSignRequest, receipts ...*client.MfaReceipt) (*client.CubeSignerResponse[models.SignResponse], error) | ||
|
|
||
| // AvaSerializedTxSign signs Avalanche transactions using the specified chainAlias (P/X/C), and materialID (address). | ||
| // request contains the serialized transaction data to be signed. | ||
| AvaSerializedTxSign(chainAlias, materialID string, request models.AvaSerializedTxSignRequest, receipts ...*client.MfaReceipt) (*client.CubeSignerResponse[models.SignResponse], error) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.