forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: temporary extras #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7841149
feat: `register.AtMostOnce.Temp{Override,Clear}()` methods
ARR4N c54d88d
feat: `params.WithTempRegisteredExtras()`
ARR4N adfef8b
Merge branch 'main' into arr4n/temporary-extras
ARR4N 3cf1438
feat: `types.WithTempRegisteredExtras()`
ARR4N 4bc3383
test: `types.WithTempRegisteredExtras()` hooks and payloads
ARR4N fb7ed1d
chore: placate the linter
ARR4N d764662
doc: allowed life of `extras` arg + self-documenting type parameter
ARR4N f35c484
doc: lack of thread safety
ARR4N 296603b
feat: `vm.WithTempRegisteredHooks()`
ARR4N 5d22eea
feat: `state.WithTempRegisteredExtras()`
ARR4N 3827f63
feat: `temporary` package for thread-safe atomic overrides
ARR4N File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
// Copyright 2025 the libevm authors. | ||
// | ||
// The libevm additions to go-ethereum are free software: you can redistribute | ||
// them and/or modify them under the terms of the GNU Lesser General Public License | ||
// as published by the Free Software Foundation, either version 3 of the License, | ||
// or (at your option) any later version. | ||
// | ||
// The libevm additions are distributed in the hope that they will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser | ||
// General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU Lesser General Public License | ||
// along with the go-ethereum library. If not, see | ||
// <http://www.gnu.org/licenses/>. | ||
|
||
package types | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/ava-labs/libevm/rlp" | ||
) | ||
|
||
type tempBlockBodyHooks struct { | ||
X string | ||
NOOPBlockBodyHooks | ||
} | ||
|
||
func (b *tempBlockBodyHooks) Copy() *tempBlockBodyHooks { | ||
return &tempBlockBodyHooks{X: b.X} | ||
} | ||
|
||
func (b *tempBlockBodyHooks) BlockRLPFieldsForEncoding(*BlockRLPProxy) *rlp.Fields { | ||
return &rlp.Fields{ | ||
Required: []any{b.X}, | ||
} | ||
} | ||
|
||
func TestTempRegisteredExtras(t *testing.T) { | ||
TestOnlyClearRegisteredExtras() | ||
t.Cleanup(TestOnlyClearRegisteredExtras) | ||
|
||
rlpWithoutHooks, err := rlp.EncodeToBytes(&Block{}) | ||
require.NoErrorf(t, err, "rlp.EncodeToBytes(%T) without hooks", &Block{}) | ||
|
||
extras := RegisterExtras[NOOPHeaderHooks, *NOOPHeaderHooks, NOOPBlockBodyHooks, *NOOPBlockBodyHooks, bool]() | ||
testPrimaryExtras := func(t *testing.T) { | ||
t.Helper() | ||
b := new(Block) | ||
got, err := rlp.EncodeToBytes(b) | ||
require.NoErrorf(t, err, "rlp.EncodeToBytes(%T) with %T hooks", b, extras.Block.Get(b)) | ||
assert.Equalf(t, rlpWithoutHooks, got, "rlp.EncodeToBytes(%T) with noop hooks; expect same as without hooks", b) | ||
} | ||
|
||
t.Run("before_temp", testPrimaryExtras) | ||
t.Run("WithTempRegisteredExtras", func(t *testing.T) { | ||
WithTempRegisteredExtras(func(extras ExtraPayloads[*NOOPHeaderHooks, *tempBlockBodyHooks, bool]) { | ||
const val = "Hello, world" | ||
b := new(Block) | ||
payload := &tempBlockBodyHooks{X: val} | ||
extras.Block.Set(b, payload) | ||
|
||
got, err := rlp.EncodeToBytes(b) | ||
require.NoErrorf(t, err, "rlp.EncodeToBytes(%T) with %T hooks", b, extras.Block.Get(b)) | ||
want, err := rlp.EncodeToBytes([]string{val}) | ||
require.NoErrorf(t, err, "rlp.EncodeToBytes(%T{%[1]v})", []string{val}) | ||
|
||
assert.Equalf(t, want, got, "rlp.EncodeToBytes(%T) with %T hooks", b, payload) | ||
}) | ||
}) | ||
t.Run("after_temp", testPrimaryExtras) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.