-
Notifications
You must be signed in to change notification settings - Fork 275
sync: coreth PR: sync changes part 2: sync_summary*
#1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is now R4R |
Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think @ceyonur should approve too
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the clock stuff
Gotcha, thanks for the feedback, should be g2g now. |
Why this should be merged
This is the second split up this PR #1679 as requested by @ceyonur. This works towards the goal of aligning the two repositories to make the transition to the coreth sync refactor simpler, and to the eventual merger of all of these files.