add initial precompile configs and handle them #226
Conversation
ceyonur
requested review from
darioush,
patrick-ogrady and
aaronbuchwald
as code owners
…bnet-evm into trustless-precompile-configs
…bnet-evm into trustless-precompile-configs
| return false | ||
| } | ||
|
|
||
| return areEqualAddressLists(c.EnabledAddresses, other.EnabledAddresses) |
There was a problem hiding this comment.
doesn't this make it impossible to change the order of addresses?
There was a problem hiding this comment.
yes. do you think we should flex this?
There was a problem hiding this comment.
Just trying to think about how this interacts with the hashing / canonical representation.
So if we wanted to make the canonical order sorted, fixing it here would make this backwards incompatible.
There was a problem hiding this comment.
We could also add a function to the interface that returns a canonical representation that can be used in hashing.
There was a problem hiding this comment.
I don't think we need to sort these lists. I think it's ok to expect the same order every time since hash(list[b,c,a]) != hash(list[a,b,c]). This is because the byte representation of those lists are not equal. JSON arrays are also ordered so users should intuitively know that providing any different list can cause issues.
There was a problem hiding this comment.
Since Equal will be used by the node locally to determine the validity of an upgrade config, if we change this in the future to be "looser" or to sort these lists, then the upgrade process should still be straight forward ie.
we push an upgrade that changes the Equal check to to define equality to ensure that the sorted list is equal and an upgrade that would have previously been invalid (ie a list in a different order, but containing the same set of addresses) will become valid, which is fine since it's just for the node's upgrade config.
We should also make sure that we do not allow duplicates in the list. Created a ticket for this here, since I think this PR is ready to merge: #269.
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
…bnet-evm into trustless-precompile-configs
Adds initial precomple configs to existing precompile so they can be activated and perform their operations through configs, without requiring an interaction with actual contracts.