Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-generator-core] added required props #333

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

mrguamos
Copy link
Contributor

This is to add support for required label on fields that are not nullable (any of "NotNull", "NotEmpty", "NotBlank")

  "components": {
    "schemas": {
      "Provider": {
        "required": [
          "firstName",
          "lastName"
        ],
        "type": "object",
        "properties": {
          "firstName": {
            "type": "string",
            "nullable": false
          },
          "middleName": {
            "type": "string"
          },
          "lastName": {
            "type": "string",
            "nullable": false
          }
        }
      }
    }
  }

Sample redoc

image

Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SentryMan
Copy link
Collaborator

your branch is out of date, update it and we should be good

@SentryMan SentryMan merged commit 7f2cc8d into avaje:master Oct 22, 2023
3 checks passed
@mrguamos mrguamos deleted the required_props branch October 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants