Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-client] Fix BeanParam on Eclipse #436

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented May 18, 2024

I guess eclipse prints out the entire method signature when doing ExecutableElement#toString()

  @Override
  public HttpResponse<InputStream> call1(Params s) {
    return client.request()
      .path("hmm")
      .queryParam("param", s.public java.lang.String getParam() )
      .queryParam("named", s.public java.lang.String getParam2() )
      .header("Head", s.public java.lang.String getHead() )
      .queryParam("publicQuery", s.publicQuery)
      .GET()
      .asInputStream();
  }

low priority, but I guess eclipse prints out the entire method signature
@SentryMan SentryMan added the bug Something isn't working label May 18, 2024
@SentryMan SentryMan self-assigned this May 18, 2024
@SentryMan SentryMan enabled auto-merge May 18, 2024 13:36
@SentryMan SentryMan changed the title Fix BeanParam on Eclipse [http-client] Fix BeanParam on Eclipse May 18, 2024
import io.avaje.http.api.Header;
import io.avaje.http.api.QueryParam;

public class Params {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not add anything to the test coverage?

We have @BeanParams in tests/test-client-generation in JunkApi and CommonParams and if we needed more coverage we would add it there?

I'll remove this I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps so, but these generator tests are what allow me to properly debug the processor with my IDE.

@rbygrave rbygrave added this to the 2.6 milestone May 21, 2024
@rbygrave rbygrave disabled auto-merge May 21, 2024 10:23
@rbygrave rbygrave merged commit db5bf8b into avaje:master May 21, 2024
3 checks passed
@SentryMan SentryMan deleted the beanParam branch May 21, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants