Skip to content

Conversation

SentryMan
Copy link
Collaborator

It occurred to me while doing open-telemetry/opentelemetry-java-instrumentation#13243, that useful com.sun.net.httpserver.Filter implementations might already exist.

  • adds configuration methods to add jdk filters to the underlying server

@SentryMan SentryMan enabled auto-merge (squash) February 11, 2025 03:37
@rbygrave
Copy link
Contributor

The potential alternative would be to have adapters from JDK Filters to Jex HttpFilter, and thus allow control the ordering for the case where someone is mixing both types of filters together.

Did you think of that and discount that option?

@SentryMan
Copy link
Collaborator Author

adapters from JDK Filters to Jex HttpFilter

Kinda got caught up in the moment, will give it a try

@SentryMan SentryMan requested a review from rbygrave February 11, 2025 04:23
@SentryMan SentryMan self-assigned this Feb 11, 2025
@SentryMan SentryMan closed this Feb 11, 2025
auto-merge was automatically disabled February 11, 2025 05:50

Pull request was closed

@SentryMan SentryMan deleted the jdkfilters branch February 13, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants