Skip to content

Fix fullUrl on jetty #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Fix fullUrl on jetty #235

merged 4 commits into from
Mar 24, 2025

Conversation

SentryMan
Copy link
Collaborator

it seems that jetty already gives the full URL so we were getting test failures like

expected: "uri:/uri/uriTest?a=av"
 but was: "uri:http://localhost:57963/uri/uriTest?a=av"

@SentryMan
fix fullUrl on jetty
18bfff2 
it seems that jetty already gives the full url
@SentryMan SentryMan enabled auto-merge (squash) March 22, 2025 05:48
@rbygrave rbygrave disabled auto-merge March 24, 2025 02:52
@rbygrave rbygrave merged commit fc608e1 into avaje:master Mar 24, 2025
4 checks passed
@SentryMan SentryMan deleted the jetty-fullurl branch March 24, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave