For collection types List, Set, Map use equals() rather than isAssign… #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able() - To support Guava ImmutableList etc When using isAssignable(), the specialised collection types like Guava ImmutableList get treated like java.util.List and this means that we don't end up using any Custom JsonAdapter that we define for those special types. Changing to use equals() means that we really expect the java.util List|Set|Map collection types to be used and no ArrayList, LinkedList etc (which would have kind of worked before but not really in that they all would have ended up as ArrayList, LinkedHashSet, LinkedHashMap. So using equals() here should be ok.
|
I had tried this approach, and ended up with something very similar to what you have. You can see my approach here: main...vamega:avaje-jsonb:varun/collection-without-assignable Some things I had done differently:
I prefer your approach of doing this in the equality test. I'm not sure if you want to support classes that have fields defined as HashMap in the core library. IME it's pretty common for objects to use HashMap/HashSet concrete class instead of the interface. Thanks for this. It seems like it will address my original issue in #405 |
SentryMan
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able() - To support Guava ImmutableList etc
When using isAssignable(), the specialised collection types like Guava ImmutableList get treated like java.util.List and this means that we don't end up using any Custom JsonAdapter that we define for those special types.
Changing to use equals() means that we really expect the java.util List|Set|Map collection types to be used and no ArrayList, LinkedList etc (which would have kind of worked before but not really in that they all would have ended up as ArrayList, LinkedHashSet, LinkedHashMap. So using equals() here should be ok.