Fix string diff colours #1287
Merged
Fix string diff colours #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechilds
force-pushed
the
fix-string-diff-colours
branch
from
5f2dad7 to
8a27671
Compare
|
Tests are failing, but other than that - works great, just tested it! |
lib/format-assert-error.js
Outdated
| const indentString = require('indent-string'); | ||
| const chalk = require('chalk'); | ||
| const diff = require('diff'); | ||
| const stripAnsi = require('strip-ansi'); |
There was a problem hiding this comment.
Could you move it above chalk?
lukechilds
force-pushed
the
fix-string-diff-colours
branch
from
8b8f998 to
4fdb263
Compare
|
Fixed test and updated |
|
Thank you, good fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all string diff output is red by default.
Resolves #1286