Improve YAML blocks in TAP reporter #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
novemberborn
commented
Mar 8, 2017
novemberborn
commented
- Properly print multiline strings (assuming \n is the line separator)
- Print additional name & message properties
- Determine 'at' value similar to serialize-error.js. Recompute since here we want the full line
- Print unhandled errors using the same logic
- Strip ANSI from actual and expected values
sindresorhus
reviewed
Mar 8, 2017
lib/reporters/tap.js
Outdated
| output.push(` name: ${yamlBlockPropertyValue(error.name)}`); | ||
| } | ||
| if (includeMessage && error.message) { | ||
| output.push(` message: ${yamlBlockPropertyValue(error.message)}`); |
There was a problem hiding this comment.
I think we need to handle quotes.
For example:
message: 'hello' this is not valid YAML
Wouldn't it be better to just use a real YAML stringifier? Like js-yaml
There was a problem hiding this comment.
Yes, not sure why I thought I could get away with the manual approach 😉
* Properly dump errors * Only print actual and expected values if they're present, and strings. This assumes they're serialized in the test workers * Strip ANSI from actual and expected values * Print additional name & message properties * Determine 'at' value similar to serialize-error.js. Recompute since here we want the full line * Print unhandled errors using the same logic
novemberborn
force-pushed
the
improve-tap-reporter
branch
from
8c34963 to
15eeb54
Compare
|
Updated. |
Merged
|
Looks good :) I wish TAP had some kind of testsuite we could run our implementation at to check for conformance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.