More assertion changes #1312
Merged
More assertion changes #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At best it saves one stack level, but AVA code is already filtered out of the stacks, so this is really quite unnecessary.
Format statements, generate diffs and otherwise format values when AssertionErrors are created. Make labels contextual to the assertion. Always print power-assert statements in mini and verbose reporters, but after the values. Accept the duplication when the statement covers the value passed to the assertion. Detect whether `t.throws()` failed because no error was thrown, or because the thrown error did not meet expectations. Explicitly test `t.fail()` default message in assertion test.
Only print the first level. For arrays/maps/objects/sets this means the indexes/keys are printed. Presumably since we do print all statements this provides enough context.
|
Damn it, Mark is on a row!
Big fan of this change, removes the need to guess what output means. |
|
LGTM as well. Great! |
|
🙌 Great as always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual/Expected, vary those labels by the assertion, depending on whether the assertion was improperly used or failed. This creates more helpful outputpretty-format.)t.regex()/t.notRegex()