Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for --config file extensions after they fail to load, allowing custom loaders #3135

Merged
merged 3 commits into from Nov 13, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Nov 1, 2022

This pushes the configFile extension check down to loadConfig() to allow experimental loaders use. If there's a loader registered that will handle an arbitrary extension loading, there's no need to throw.

Resolves #3134

@novemberborn
Copy link
Member

Yes this could work. What I'd need to double check is how this interfaces with ambiguous config-file detection.

Would you use this with the --config option?

@panva
Copy link
Contributor Author

panva commented Nov 7, 2022

Would you use this with the --config option?

Yes.

Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panva cool! Having refamiliarized myself with the loader logic I think this is a good addition to make loaders possible.

Let's see what CI says.

@novemberborn
Copy link
Member

#3137 should fix the Node.js 16 failures.

@novemberborn novemberborn changed the title refactor: push config file extension checks a bit to allow loaders Check for --config file extensions after they fail to load, allowing custom loaders Nov 13, 2022
@novemberborn novemberborn merged commit 647d3e1 into avajs:main Nov 13, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow resolve config file to use loaders
2 participants