Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MAX_LENGTH constants in pelib to reflect what we see in the wild #957

Closed
metthal opened this issue May 31, 2021 · 0 comments · Fixed by #978
Closed

Bump MAX_LENGTH constants in pelib to reflect what we see in the wild #957

metthal opened this issue May 31, 2021 · 0 comments · Fixed by #978

Comments

@metthal
Copy link
Member

metthal commented May 31, 2021

We've ran into some samples which contain very long symbols which can be considered valid. There are however several MAX_LENGTH constants in PeLib which limit them to 96. It'd be the best to push these constants further so that we can realistically parse out what is possible but still with reasonable constraints (let's say 256, 384 or 512 in the worst case). They are all located in include/retdec/pelib/PeLibAux.h but try to look through the whole pelib folder to find other limit constants.

Sample for test: 1c9620c688d00703a5c535ffbd59f27f5f7da07b18ccb12aef480ac2c0222324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants