Increased PE symbols MAX_LENGTH limits #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this, but I think exports could/should be capped as well. What does @metthal think? We could create another issue for this... |
PeterMatula
approved these changes
Jul 12, 2021
PeterMatula
added a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957
It seems there are 3 constants in the header:
I was wondering why isn't there a constant for exported symbols. It seems that for exported symbols there is no "sanity" length cap, it's capped by the default max value of the
read()function (which is used to read the string from the image) which is 65535. I haven't seen any other MAX length constants in the pelib headers.Based on the example binary I've raised those 3 constants to 256.