Skip to content

feat: Implement Redis support via Lettuce #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2020
Merged

feat: Implement Redis support via Lettuce #382

merged 3 commits into from
Nov 19, 2020

Conversation

jakubjanecek
Copy link
Collaborator

Closes #51

@sideeffffect
Copy link
Contributor

Why not just https://github.com/profunktor/redis4cats ?

@jakubjanecek
Copy link
Collaborator Author

Because I am using Lettuce. We can have both if we need to, can't we?

@sideeffffect
Copy link
Contributor

I'm not stopping you. But clearly redis4cats should be recommended over the other and you should consider using it too.
The PR it self is fine.

@jakubjanecek jakubjanecek merged commit 3b4232f into master Nov 19, 2020
@jakubjanecek jakubjanecek deleted the feat/51/redis branch November 19, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanny24 hanny24 Awaiting requested review from hanny24

1 more reviewer

@sideeffffect sideeffffect sideeffffect approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add module for Redis client
2 participants
@jakubjanecek @sideeffffect