Skip to content

TimeUtils.timeCase/FOps.timeCase added #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2021
Merged

TimeUtils.timeCase/FOps.timeCase added #492

merged 1 commit into from
Mar 14, 2021

Conversation

jendakol
Copy link
Contributor

Improvement of existing functionality for better error case reporting.

I was thinking about creating a custom sealed trait or using the ExitCase directly, but Either fits quite well I think.

@jendakol jendakol requested a review from jakubjanecek March 14, 2021 15:26
jakubjanecek
jakubjanecek approved these changes Mar 14, 2021
View reviewed changes
Copy link
Collaborator

@jakubjanecek jakubjanecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

@jakubjanecek jakubjanecek merged commit 456aee2 into master Mar 14, 2021
@jakubjanecek jakubjanecek deleted the feature/FOps.timeCase branch March 14, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjanecek jakubjanecek jakubjanecek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jendakol @jakubjanecek