Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gotrace #2401

Closed
wants to merge 1 commit into from
Closed

add gotrace #2401

wants to merge 1 commit into from

Conversation

fkromer
Copy link

@fkromer fkromer commented Mar 3, 2019

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

cassiobotaro
cassiobotaro requested changes Mar 6, 2019
View reviewed changes
Copy link
Collaborator

@cassiobotaro cassiobotaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkromer Please provide links for the library.

@fkromer
Copy link
Author

fkromer commented Mar 9, 2019

Please provide links for the library.

Probably it's not obvious from the PR only: The visualization tool is mainly written in JavaScript. Only the instrumentation for Go code is written in Go. I guess the reason for no tests is that a lot of code depends on the patched Go runtime and testing could be hard to impossible.

  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.

@fkromer fkromer closed this Mar 9, 2019
@fkromer fkromer mentioned this pull request Mar 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassiobotaro cassiobotaro cassiobotaro requested changes

Assignees
No one assigned
Labels
needs links pending-submitter-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkromer @cassiobotaro