Skip to content

Conversation

adarshkushwah
Copy link
Contributor

Description

This script keeps track of the network data usage and notifies the user if it exceeds a defined limit.

Fixes #(16)

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have created a helpful and easy to understand README.md
  • My changes generate no new warnings

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan avinashkranjan linked an issue Oct 11, 2020 that may be closed by this pull request
@avinashkranjan avinashkranjan self-requested a review October 11, 2020 07:04
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve this error

vmware_4CHI2sv3rt

@adarshkushwah
Copy link
Contributor Author

Please provide me the info on the below from your environment :

  • Vnstat version
  • Python3 version
  • Python3-tk version (it should probably be similar to that of Python3)
  • OS info

Will need to take the environment variables into consideration as well i guess, as I tested this on my system and on an another test virtual environment but it appears to be working fine.

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..🚀 Works Now..

@avinashkranjan avinashkranjan merged commit 6b18e54 into avinashkranjan:master Oct 13, 2020
@avinashkranjan
Copy link
Owner

@all-contributors please add @adarshkushwah for code and documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @adarshkushwah! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Script to track Data Usage
2 participants