Skip to content

Conversation

RohiniRG
Copy link
Contributor

@RohiniRG RohiniRG commented May 21, 2021

Description

The Pomodoro technique uses a timer to break down work into intervals, traditionally 25 minutes in length, separated by 5 min breaks. The python script is represented in a GUI based form along with an extra functionality of website blocking to prevent distractions.

Fixes #1044

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • I have added the project meta data in the PR template.
  • I have created the requirements.txt file if needed.

Project Metadata

If there is no-file/nothing to fill the below fields with, then type: none

Example: If no requirements.txt needed/present, then type none in Requirments.

Category:

  • Calculators
  • AI/ML
  • Scrappers
  • Social_Media
  • PDF
  • Image_Processing
  • Video_Processing
  • Games
  • Networking
  • OS_Utilities
  • Automation
  • Cryptography
  • Computer_Vision
  • Fun
  • Others

Title: Pomodoro clock with GUI

Folder: Pomodoro_GUI

Requirements: requirements.txt

Script: Pomodoro_gui.py.

Arguments: None

Contributor: RohiniRG

Description: The Pomodoro technique uses a timer to break down work into intervals, traditionally 25 minutes in length, separated by 5 min breaks. The python script is represented in a GUI-based form along with extra functionality of website blocking to prevent distractions.

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some enhancements:

Comment on lines 15 to 21
block_list = [
'www.facebook.com', 'facebook.com',
'www.youtube.com', 'youtube.com',
'www.gmail.com', 'gmail.com',
'www.instagram.com', 'instagram.com',
'www.twitter.com', 'twitter.com'
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get this input via GUI? it will make the script more customizable.

except:
pass

pygame.mixer.music.load("beep.wav")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pygame.mixer.music.load("beep.wav")
pygame.mixer.music.load("./Pomodoro_GUI/beep.wav")

root.title('Timer')
root.geometry('470x608')

bg = tk.PhotoImage(file = "bg.png")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bg = tk.PhotoImage(file = "bg.png")
bg = tk.PhotoImage(file = "./Pomodoro_GUI/bg.png")

@kaustubhgupta kaustubhgupta added the enhancement New feature or request label May 22, 2021
@RohiniRG
Copy link
Contributor Author

Some enhancements:

Yes, I will try to implement this.
But @kaustubhgupta could you please consider upgrading the level for this issue, as I believe I had to put a lot more work into this than other level2 issues I have submitted for this repo.

@kaustubhgupta
Copy link
Contributor

Some enhancements:

Yes, I will try to implement this.
But @kaustubhgupta could you please consider upgrading the level for this issue, as I believe I had to put a lot more work into this than other level2 issues I have submitted for this repo.

will consider that after the script is ready to be approved 👍

@RohiniRG
Copy link
Contributor Author

@kaustubhgupta have a look

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, increased the level as promised :)

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed enhancement New feature or request labels May 24, 2021
@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels May 25, 2021
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..

@avinashkranjan avinashkranjan added the manual-db-update-req The PR was merged but db was not updated. Need to update the database manully label May 27, 2021
@avinashkranjan avinashkranjan merged commit 177a0a7 into avinashkranjan:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing manual-db-update-req The PR was merged but db was not updated. Need to update the database manully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pomodoro clock GUI
4 participants