Skip to content

Conversation

Mr-Mishraji
Copy link
Contributor

@Mr-Mishraji Mr-Mishraji commented Oct 17, 2020

Description

fixed the code so that it can save pdf file into mp3 file of the same name as pdf and the same directory where pdf file is . one more library added (gTTS).

Fixes #(108)

Replace 108 with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan
Copy link
Owner

Ohh Great..Thanks For Contributing..

@avinashkranjan avinashkranjan self-requested a review October 17, 2020 16:15
@avinashkranjan avinashkranjan linked an issue Oct 17, 2020 that may be closed by this pull request
@Mr-Mishraji
Copy link
Contributor Author

@Mr-Mishraji Please create a Issue for the Same..

ohk

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..🚀

@avinashkranjan avinashkranjan merged commit 0310f27 into avinashkranjan:master Oct 17, 2020
@Mr-Mishraji
Copy link
Contributor Author

LGTM..🚀

still I have to create issue

@avinashkranjan
Copy link
Owner

LGTM..🚀

still I have to create issue
No..No It's alright...

@all-contributors please add @Mr-Mishraji for code

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @Mr-Mishraji! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Script to Convert PDF book into Audiobook.
2 participants