Skip to content

Conversation

shubhigupta991
Copy link
Contributor

@shubhigupta991 shubhigupta991 commented Jan 5, 2021

Description

Added Reddit-scraping-and-flair-detection folder

Fixes #161

Have you read the Contributing Guidelines on Pull Requests?

  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan
Copy link
Owner

@shubhigupta991 How does this solve #56 Issue?

@shubhigupta991
Copy link
Contributor Author

@shubhigupta991 How does this solve #56 Issue?

really sorry i linked the wrong issue. I have corrected my mistake its issue #161

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Great Job

@avinashkranjan avinashkranjan merged commit 6bb6c1d into avinashkranjan:master Jan 7, 2021
@avinashkranjan
Copy link
Owner

@all-contributors please add @shubhigupta991 for code and documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @shubhigupta991! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scraping and flare detection

2 participants